Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add url polyfill #3182

Merged
merged 2 commits into from Dec 1, 2017
Merged

Add url polyfill #3182

merged 2 commits into from Dec 1, 2017

Conversation

llienher
Copy link
Member

Fixes #3085

Should allow Url polyfill to be used in the projects.

Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a little required change

Makefile Outdated
@@ -69,6 +70,7 @@ GMF_APPS_LIBS_JS_FILES += \
node_modules/corejs-typeahead/dist/typeahead.bundle.min.js \
node_modules/jsts/dist/jsts.min.js \
node_modules/moment/min/moment.min.js \
node_modules/url-polyfill/url-polyfill.js \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use min file ...

@llienher
Copy link
Member Author

@sbrunner I made the change for minified file, is everything ok now ?

@llienher llienher changed the title [WIP] Add url polyfill Add url polyfill Dec 1, 2017
@llienher llienher merged commit 2cfd4dc into 2.2 Dec 1, 2017
@llienher llienher deleted the url_polyfill branch December 1, 2017 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants