Display label drawing #3269
Merged
Display label drawing #3269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julsbreakdown
force-pushed
the
jwaddle_display_label_drawing
branch
4 times, most recently
from
f16c03b
to
cd81f45
Compare
julsbreakdown
force-pushed
the
jwaddle_display_label_drawing
branch
4 times, most recently
from
1a9fa35
to
77d9790
Compare
julsbreakdown
force-pushed
the
jwaddle_display_label_drawing
branch
from
77d9790
to
03d9610
Compare
julsbreakdown
changed the title
sbrunner
reviewed
Dec 15, 2017
src/services/featurehelper.js
Outdated
| text: this.getNameProperty(feature), | ||
| offsetY: -(offset / 2 + 4) | ||
| }) | ||
| })); |
There was a problem hiding this comment.
@fredj is this offset calculation correct?
There was a problem hiding this comment.
This 25 looks to be a magic number, shouln't we use multiline from OpenLayers: openlayers/openlayers#4512?
src/services/featurehelper.js
Outdated
| text: this.getNameProperty(feature), | ||
| offsetY: -(offset / 2 + 4) | ||
| }) | ||
| })); |
src/services/featurehelper.js
Outdated
| size: 10, | ||
| offsetY: -(offset / 2 + 4) | ||
| }) | ||
| })); |
|
In this case we only have the one style for the label, and use the multiline ('/n' option) if both (measure & label are checked)? |
|
Yes :-) |
sbrunner
approved these changes
Dec 18, 2017
src/services/featurehelper.js
Outdated
| if (showLabel && showMeasure){ | ||
| // display both label using \n | ||
| textLabelValue = textProperty + '\n' +textMeasure; | ||
| } |
There was a problem hiding this comment.
We usely do like this:
cost textLabelValues = [];
textLabelValues.push(this.getNameProperty(feature));
textLabelValues.push(this.getMeasure(feature));
cost textLabelValue = textLabelValues.join('\n');=> shorter and no if :-)
julsbreakdown
force-pushed
the
jwaddle_display_label_drawing
branch
9 times, most recently
from
ab841e1
to
448a4c6
Compare
julsbreakdown
force-pushed
the
jwaddle_display_label_drawing
branch
from
448a4c6
to
2160812
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable the user to display the feature label.
As it is done for the measurement label.
cf