Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some docs fix #3298

Merged
merged 2 commits into from Dec 20, 2017
Merged

Some docs fix #3298

merged 2 commits into from Dec 20, 2017

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Dec 20, 2017

Fix #3255

@sbrunner sbrunner added this to the 2.2 milestone Dec 20, 2017
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look at my comment but it looks good

@@ -86,7 +86,7 @@ gmf.displayquerygridComponent = {
bindings: {
'active': '=?gmfDisplayquerygridActive',
'featuresStyleFn': '&gmfDisplayquerygridFeaturesstyle',
'selectedFeatureStyleFn': '&gmfDisplayquerygridSourceselectedfeaturestyle',
'selectedFeatureStyleFn': '&gmfDisplayquerygridSelectedfeaturestyle',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now the attribute name will be:
gmf-displayquerygrid-selectedfeaturestyle
(it was gmf-displayquerygrid-sourceselectedfeaturestyle)

It is what you want ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the doc, yes.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And I don't see any use of it...

@sbrunner sbrunner merged commit 6238557 into 2.2 Dec 20, 2017
@sbrunner sbrunner deleted the docs branch December 20, 2017 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants