Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix highlight features in display query grid #3301

Merged
merged 1 commit into from Dec 21, 2017
Merged

Fix highlight features in display query grid #3301

merged 1 commit into from Dec 21, 2017

Conversation

sbrunner
Copy link
Member

Fix #3252

I make it similar as displayquerywindow.js

@sbrunner sbrunner added this to the 2.2 milestone Dec 20, 2017
ger-benjamin
ger-benjamin requested changes Dec 20, 2017
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will work but it's better to do it like the highlightFeatureStyle right under.
(better because more coherent and we don't need to assign the ngeoFeatureOverlayMgr into the displaygridController class)

@sbrunner
Copy link
Member Author

... I don't understand

@sbrunner sbrunner force-pushed the features-grid branch 4 times, most recently from 2f3ca88 to 4af62fc Compare December 21, 2017 08:40
@sbrunner
Copy link
Member Author

Done :-)

ger-benjamin
ger-benjamin approved these changes Dec 21, 2017
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks

@sbrunner sbrunner merged commit 1157d1d into 2.2 Dec 21, 2017
@sbrunner sbrunner deleted the features-grid branch December 21, 2017 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

@fredj fredj Awaiting requested review from fredj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @ger-benjamin