Allow bloodhound rateLimitWait params to be settable in gmf #3343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
approved these changes
Jan 8, 2018
pfirpfel
reviewed
Jan 9, 2018
| @@ -298,6 +302,12 @@ gmf.SearchController = function($scope, $compile, $timeout, $injector, gettextCa | |||
| */ | |||
| this.placeholder; | |||
|
|
|||
| /** | |||
| * @type {string} | |||
There was a problem hiding this comment.
@type {string} shouldn't this be @type {number}
llienher
force-pushed
the
gmf-search-delay
branch
from
e185b2a
to
920d5f3
Compare
fredj
approved these changes
Jan 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allow the rateLimitWait parameter, that is used with the Bloodhound engine for debouncing fulltext-search requests, to be set up. That allow as well to set different values for each interfaces. Like mobile could get a higher value in order to get less request / bandwidth used with the backend for fulltext-search.
If the value is not set from the directive html, or not existing in the interface controller, the search component is going to set it to the default value: 50 ms. This was the value we previously hard-coded. There should be no issue for project that have outdated html for the search component as the component is going to initialize the value correctly in any cases.
I updated every interface, only desktop_alt have a different value that the default one.
Fixed the gmf example as well.