Mouse position translation #3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Jan 9, 2018
| @@ -64,32 +65,64 @@ gmf.MousepositionController = function($element, $filter, gettextCatalog) { | |||
| */ | |||
| this.projection; | |||
|
|
|||
| /** | |||
| * @type {angular.Scope} | |||
| * | |||
gberaudo
reviewed
Jan 9, 2018
| * @type {angularGettext.Catalog} | ||
| * @private | ||
| */ | ||
| this.gettextCatalog_ = gettextCatalog; |
There was a problem hiding this comment.
FWIW, you can mark it protected and remove the trailing underscore. Then there is no need to alias it in the code below.
llienher
force-pushed
the
mouse-position-translation
branch
from
8ab466f
to
3ecfa8b
Compare
gberaudo
approved these changes
Jan 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3344
This fixes the translation issue with the mouse position OL control. Now we wait for gettextCatalog to fire an event that the language is loaded/changed to create the component with the correct language string.