Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some fix for the permalink #3367

Merged
merged 1 commit into from Jan 12, 2018
Merged

Some fix for the permalink #3367

merged 1 commit into from Jan 12, 2018

Conversation

sbrunner
Copy link
Member

fix #3352

@sbrunner sbrunner added this to the 2.2 milestone Jan 10, 2018
@sbrunner sbrunner force-pushed the permalink branch 2 times, most recently from 49b9948 to 5d009be Compare January 11, 2018 08:08
ger-benjamin
ger-benjamin reviewed Jan 11, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mhhh the TreeManager need the permalink and the permalink need the TreeManager. I hope that's not a problem...

contribs/gmf/src/services/permalink.js
}
return false;
} else {
return layer.get('layerNodeName') == name;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's working with WMTS layers, WMS mixed layers, etc ? (all cases ?)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just tested again, and effectively it's working for WMS and WMTS :-)

ger-benjamin
ger-benjamin approved these changes Jan 11, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, so, let's move on :-)

@sbrunner sbrunner force-pushed the permalink branch 6 times, most recently from 9fdf41d to d475e4d Compare January 12, 2018 08:43
@sbrunner sbrunner merged commit 9fd5afb into 2.2 Jan 12, 2018
@sbrunner sbrunner deleted the permalink branch January 12, 2018 14:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

@fredj fredj Awaiting requested review from fredj

@gberaudo gberaudo Awaiting requested review from gberaudo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @ger-benjamin