Set the background layer from the them at page load #3382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
force-pushed
the
bg_layer_from_theme
branch
from
c4da277
to
a5db7a8
Compare
sbrunner
approved these changes
Jan 16, 2018
sbrunner
reviewed
Jan 16, 2018
| @@ -922,8 +922,7 @@ gmf.Permalink.prototype.initLayers_ = function() { | |||
| const themeName = this.defaultThemeName(); | |||
|
|
|||
| if (this.gmfThemeManager_ && this.gmfThemeManager_.modeFlush) { | |||
| // Set theme in stealth mode, we just want to set the theme name, not more. | |||
| this.gmfThemeManager_.setThemeName(`${themeName}`, true); | |||
| this.gmfThemeManager_.setThemeName(themeName); | |||
There was a problem hiding this comment.
There a missing goog.asserts.assert ...
fredj
force-pushed
the
bg_layer_from_theme
branch
from
a5db7a8
to
a835e76
Compare
fredj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correctly set the background layer at page load.
Change: at page load, the theme name is directly set to the url; it was not the case previously.