Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix draw issues #3407

Merged
merged 2 commits into from Jan 18, 2018
Merged

Fix draw issues #3407

merged 2 commits into from Jan 18, 2018

Conversation

sbrunner
Copy link
Member

Fix #3401

@sbrunner sbrunner added this to the 2.2 milestone Jan 18, 2018
@sbrunner sbrunner requested a review from fredj January 18, 2018 08:25
@sbrunner sbrunner changed the title Fiy draw issues Fix draw issues Jan 18, 2018
fredj
fredj approved these changes Jan 18, 2018
View reviewed changes
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please note that exceedLength was renamed to overflow in ol 4.6.0: https://github.com/openlayers/openlayers/blob/master/changelog/v4.6.0.md#renamed-exceedlength-option-of-olstyletext-to-overflow

we must take this into account when merging 2.2 into master

@sbrunner
Copy link
Member Author

Effectively, thanks for the notice :-)

@sbrunner sbrunner merged commit 85af76e into 2.2 Jan 18, 2018
@sbrunner sbrunner deleted the draw branch January 18, 2018 10:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.2.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @fredj