Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add printNativeAngle parameter to the gmf-created print LayerGroup #3452

Merged
merged 1 commit into from Feb 1, 2018

Conversation

llienher
Copy link
Member

@llienher llienher commented Jan 25, 2018

I set the parameter this way in a project controller via metadata 'printNativeAngle' in the admin interface applied to the layer group I want.

printNativeAngle value was not sent to the ngeo print component because gmf did not retrieve the original layerGroup but create a new one just before sending it to ngeo.

Desktop_alt updated to test this use case.

@llienher llienher changed the title Add printNativeAngle parameter to the gmf-created print LayerGroup [WIP] Add printNativeAngle parameter to the gmf-created print LayerGroup Jan 29, 2018
treeCtrl.traverseDepthFirst((ctrl) => {
console.log(ctrl);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be removed

@llienher llienher force-pushed the gmf_print-native-angle branch 2 times, most recently from af3d2ff to 5eff4d2 Compare January 31, 2018 10:23
@llienher llienher changed the title [WIP] Add printNativeAngle parameter to the gmf-created print LayerGroup Add printNativeAngle parameter to the gmf-created print LayerGroup Jan 31, 2018
@llienher
Copy link
Member Author

Tested on my gmf internal instance, was working with the 'printNativeAngle' metadata added in the vars_project.

@sbrunner This is ready for review.

@sbrunner
Copy link
Member

Can you squash your commits...

Update translation file wget path in Makefile

Update desktop_alt app example

Use metadata instead of controller to initialize the parameter

Sync layers with printNativeAngle attribute

Add printNativeAngle in externs metadata

Fix if condition
@llienher
Copy link
Member Author

@sbrunner Done :-)

Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@llienher llienher merged commit 0536a06 into 2.2 Feb 1, 2018
@llienher llienher deleted the gmf_print-native-angle branch February 1, 2018 07:19
@sbrunner sbrunner added this to the 2.2 milestone Apr 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants