Debug login errors and force-password-change message #3484
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid AngularJs error: $compile:multilink Linking Element Multiple Times
ger-benjamin
changed the title
llienher
reviewed
Feb 7, 2018
There was a problem hiding this comment.
About the timeout, just open question. Is it not possible to emit the event just after the 'soft' reload (as we know this state happens when we log) ? That would remove the need for timout, but I'm not sure if it is even possible or hard to implement this way... Maybe timemout is just the easier/logical way to handle this.
ger-benjamin
force-pushed
the
debug_login
branch
from
5a2bde1
to
0885cf4
Compare
|
I thought that the reste was done in the abstract controller, and it this case, it should be hard to debug on your way @llienher . But in fact, the problem was just a reset function (in the auth directive) called before the event was launched. I've reworked the second commit. Now the solution is far more logical and suits me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First commit fix a $compile:multiling Linking Element Multiple Times angular error.
Second commit fix: #3278
The problem is that the READY event was not emitted on login (but I need it, and it looks not problematic to emit it at the same time as the LOGIN event.) Then, the problem is that the "soft" reload of the page remove the notification, I've used a timeout to avoid this problem. If you know a better method...