Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2.3] Add missing ng-if to desktop interface #3905

Merged
merged 1 commit into from May 23, 2018
Merged

[2.3] Add missing ng-if to desktop interface #3905

merged 1 commit into from May 23, 2018

Conversation

llienher
Copy link
Member

Backport #3904 into 2.3 branch.

@llienher llienher added this to the 2.3 milestone May 23, 2018
@llienher llienher self-assigned this May 23, 2018
@gberaudo
Copy link
Member

There is also contribs/gmf/examples/share.html missing the ng-if.

@llienher
Copy link
Member Author

@gberaudo Good catch, I gonna fix the example in an other PR to not make this one (backport) diverge from the initial one and makes thing confusing.

@sbrunner sbrunner merged commit 1f0e950 into 2.3 May 23, 2018
@sbrunner sbrunner deleted the fix_share_modal_for_desktop_23 branch May 23, 2018 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

@fredj fredj Awaiting requested review from fredj

@ger-benjamin ger-benjamin Awaiting requested review from ger-benjamin

@gberaudo gberaudo Awaiting requested review from gberaudo

Assignees

@llienher llienher

Labels
None yet
Projects
None yet
Milestone
2.3.1
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@llienher @gberaudo @sbrunner