Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Phpdate format es6 #4001

Merged
merged 2 commits into from Jul 4, 2018
Merged

Phpdate format es6 #4001

merged 2 commits into from Jul 4, 2018

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Jul 3, 2018

@sbrunner sbrunner added this to the dummy milestone Jul 3, 2018
@sbrunner sbrunner force-pushed the phpdate-format-es6 branch 2 times, most recently from df6ef47 to a05f897 Compare July 3, 2018 12:05
gberaudo
gberaudo reviewed Jul 4, 2018
View reviewed changes
src/misc/php-date-formatter.js Outdated

/*eslint valid-jsdoc: 0 */
/*eslint quotes: 0 */
/*eslint indent: 0 */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cannot we fix indent?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes but upstream they use 4 spaces indent, than I prefer to keep as it...

gberaudo
gberaudo approved these changes Jul 4, 2018
View reviewed changes
Copy link
Member

@gberaudo gberaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it does not beak stuff I think it is worth it.

@sbrunner sbrunner merged commit 576ba31 into master Jul 4, 2018
@sbrunner sbrunner deleted the phpdate-format-es6 branch July 4, 2018 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberaudo gberaudo gberaudo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
dummy
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @gberaudo