Import KML: Manage Empty geometry import error #4080
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
force-pushed
the
stop_import_bad_file
branch
from
1cb4a6c
to
dfd131c
Compare
fredj
reviewed
Jul 31, 2018
| } | ||
| // Look if the extent is valid (and so at least one geometry) | ||
| if (dataSource.extent[0] === Infinity) { | ||
| console.error('The file contains no geometry'); |
There was a problem hiding this comment.
do we want to keep this console.error?
There was a problem hiding this comment.
Not specially, There is already a warning to the user that says "bad file".
Should I remove it ?
fredj
reviewed
Jul 31, 2018
| return; | ||
| } | ||
| // Look if the extent is valid (and so at least one geometry) | ||
| if (dataSource.extent[0] === Infinity) { |
There was a problem hiding this comment.
maybe the isEmpty function could be used:
import {isEmpty} from 'ol/extent.js';
if (isEmpty(dataSource.extent)) {
fredj
approved these changes
Jul 31, 2018
ger-benjamin
force-pushed
the
stop_import_bad_file
branch
from
dfd131c
to
06a461e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GSGMF-573