Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

some Bootstrap fix #4122

Merged
merged 4 commits into from Aug 14, 2018
Merged

some Bootstrap fix #4122

merged 4 commits into from Aug 14, 2018

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner sbrunner added this to the 2.3 milestone Aug 13, 2018
@sbrunner sbrunner force-pushed the bootstrap branch 2 times, most recently from 0d01bd3 to cd19c20 Compare August 14, 2018 06:25
@@ -69,6 +69,10 @@ main {
overflow: hidden;
}

.btn {
padding: calc(5rem/16) calc(10rem/16)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

5rem/16 = 0.3125 = $half-app-margin
10rem/16 = 0.625 = $app-margin
So why not using these variables ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ignoring, thanks, fixed :-)

Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@sbrunner sbrunner merged commit 2abbb91 into master Aug 14, 2018
@sbrunner sbrunner deleted the bootstrap branch August 14, 2018 08:06
@sbrunner sbrunner modified the milestones: 2.3, 2.4 Aug 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants