Fix Font Awesome icons #4142
Merged
Fix Font Awesome icons #4142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Aug 21, 2018
| @@ -60,7 +60,7 @@ | |||
| <button ngeo-mobile-geolocation="" | |||
| ngeo-mobile-geolocation-map="::mainCtrl.map" | |||
| ngeo-mobile-geolocation-options="::mainCtrl.mobileGeolocationOptions"> | |||
| <span class="fa fa-dot-circle-o"></span> | |||
| <span class="far fa-dot-circle"></span> | |||
There was a problem hiding this comment.
I'm not sure we should have a mix of fa and far classes
There was a problem hiding this comment.
In this case, we won't have the symbol we want... Should we find another one ?
(that can have sens, because here, it's the only place where we need the "regular" FA library)
There was a problem hiding this comment.
@fredj https://fontawesome.com/icons/dot-circle?style=regular The solid one don't match our needs. And we can't use always the "regular" police because the search is not free.
sbrunner
approved these changes
Aug 21, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GSGMF-418
Some icons needs to have specified
font-weight: 900to be displayed