Be able to configure the Print GetLegendGraphics #4146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Aug 23, 2018
contribs/gmf/src/print/component.js
Outdated
| /** | ||
| * @typedef {{ | ||
| * bbox: (boolean|undefined), | ||
| * label: (Object.<String, boolean>) |
contribs/gmf/src/print/component.js
Outdated
| @@ -201,6 +209,7 @@ exports.Controller_ = class { | |||
| * @param {angular.$filter} $filter Angular $filter service. | |||
| * @param {gmf.print.component.PrintStateEnum} gmfPrintState GMF print state. | |||
| * @param {gmf.theme.Themes} gmfThemes The gmf Themes service. | |||
| * @param {gmfLegendOptionsType} gmfiPrintLegendOptions The legend options | |||
contribs/gmf/src/print/component.js
Outdated
| @@ -176,6 +176,14 @@ exports.component_ = { | |||
|
|
|||
| exports.component('gmfPrint', exports.component_); | |||
|
|
|||
| /** | |||
| * @typedef {{ | |||
| * bbox: (boolean|undefined), | |||
There was a problem hiding this comment.
Can we name it haveBbox or useBbox ? or something like that ?
(Or it's too long to change ?)
sbrunner
force-pushed
the
print-qgis
branch
2 times, most recently
from
803dedf
to
586e40c
Compare
sbrunner
force-pushed
the
print-qgis
branch
3 times, most recently
from
37478d1
to
480e710
Compare
sbrunner
force-pushed
the
print-qgis
branch
2 times, most recently
from
9fe737d
to
10a4ef3
Compare
fredj
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.