Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add raster layers unit #4209

Merged
merged 1 commit into from Sep 6, 2018
Merged

Add raster layers unit #4209

merged 1 commit into from Sep 6, 2018

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Sep 5, 2018

@sbrunner sbrunner added this to the 2.3 milestone Sep 5, 2018
ger-benjamin
ger-benjamin approved these changes Sep 5, 2018
View reviewed changes
Copy link
Member

@ger-benjamin ger-benjamin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, now, we can't choose anymore the number of digit ?

@sbrunner
Copy link
Member Author

sbrunner commented Sep 5, 2018

Effectively I will add this possibility :-)

@sbrunner sbrunner force-pushed the rasterlayer-unit branch 4 times, most recently from 8bfcbdf to ef58f49 Compare September 6, 2018 09:25
ger-benjamin
ger-benjamin reviewed Sep 6, 2018
View reviewed changes
contribs/gmf/src/raster/component.js Outdated
* </span>
*
* For value in meter `elevationLayersConfig` can be en empty object, complex example:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can be en empty object -> an

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

contribs/gmf/apps/desktop/Controller.js Outdated
@@ -60,6 +60,12 @@ const exports = function($scope, $injector) {
*/
this.elevationLayers = ['aster', 'srtm'];

/**
* @type {Array.<gmf.mobile.measure.pointComponent.LayerConfig>}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong type

contribs/gmf/src/raster/component.js Outdated
*
* @htmlAttribute {boolean} gmf-elevation-active A boolean to set active or
* deactive the component.
* @htmlAttribute {number} gmf-elevation-elevation The value to set with the
* elevation value.
* @htmlAttribute {string} gmf-elevation-layer Elevation layer to use.
* @htmlAttribute {Array.<gmf.mobile.measure.pointComponent.LayerConfig>} gmf-elevation-layerconfig Elevation layer configurations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong type

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gmf-elevation-layersconfig

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

contribs/gmf/src/raster/component.js Outdated
@@ -132,13 +153,19 @@ exports.Controller_ = function($scope, ngeoDebounce, gmfRaster) {
*/
this.gmfRaster_ = gmfRaster;

/**
* @type {!Array.<gmf.mobile.measure.pointComponent.LayerConfig>}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed :-)

contribs/gmf/src/raster/component.js Outdated
@@ -313,6 +354,12 @@ exports.WidgetController_ = function() {
*/
this.layers;

/**
* @type {!Array.<gmf.mobile.measure.pointComponent.LayerConfig>}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong type

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed :-)

contribs/gmf/src/raster/component.js
* separator: (string|undefined)
* }}
*/
exports.LayerConfig;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

layersConfig

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's just for one layer ..., I use it as Object.<string, gmf.raster.component.LayerConfig> for layers config :-)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's right, sorry

@sbrunner sbrunner merged commit dfad709 into 2.3 Sep 6, 2018
@sbrunner sbrunner deleted the rasterlayer-unit branch September 6, 2018 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ger-benjamin ger-benjamin ger-benjamin approved these changes

@fredj fredj Awaiting requested review from fredj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @ger-benjamin