Fix 652 - Bootstrap 4 dropdown-menu use 'show' instead of 'open' #4241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adube
force-pushed
the
V2_4-652-fix-filter-criterias
branch
2 times, most recently
from
0f5ef9a
to
d5e0b1e
Compare
adube
force-pushed
the
V2_4-652-fix-filter-criterias
branch
from
d5e0b1e
to
5b06d8e
Compare
|
@arnaud-morvan Ready for review. |
|
@fredj Would you please take care of the review? This is a very small one. |
adube
force-pushed
the
V2_4-652-fix-filter-criterias
branch
from
5b06d8e
to
d3f4058
Compare
|
Rebase onto master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the issue that occurs in the filter "rule component", i.e. when selecting an attribute in the filter tool, the dropdown menu was not opened. Clicking on the drop-down list did show the menu, but in the background we had a broken state.
Cause: in Bootstrap 4, the class
showhas to be used on the element with the css classdropdown-menu, see (inspect the drop down menu when opened, you'll see the "show" css class name":https://www.w3schools.com/bootstrap4/tryit.asp?filename=trybs_dropdown-menu&stacked=h
In Bootstrap 3, this was different. The css class
openhad to be set on the element with thedropdowncss class.