Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 645 - Draw feature, close menu #4244

Merged
merged 1 commit into from Sep 19, 2018

Conversation

adube
Copy link
Contributor

@adube adube commented Sep 17, 2018

In the drawing tool, a.k.a. "redlining", when we right-click on a feature, make sure to close any existing menu.

@sbrunner
Copy link
Member

Should be on branch 2.3

@adube
Copy link
Contributor Author

adube commented Sep 18, 2018

Should be on branch 2.3

Jira marks this as 2.4.

I also can't reproduce the issue in 2.3, see: https://camptocamp.github.io/ngeo/2.3/examples/contribs/gmf/apps/desktop.html

Is this really 2.4?

@adube
Copy link
Contributor Author

adube commented Sep 18, 2018

FYI, this is really for 2.4. Ready for review.

@adube adube requested a review from sbrunner September 18, 2018 13:00
@adube adube force-pushed the v2_4-645-fix-editing-context-menu branch from 7052f7e to c30a04b Compare September 18, 2018 13:03
@adube adube merged commit 7c8cb36 into camptocamp:master Sep 19, 2018
@adube adube deleted the v2_4-645-fix-editing-context-menu branch September 19, 2018 12:15
@sbrunner sbrunner added this to the 2.4 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants