Fix 607 - Format http(s) links and emails as <a> in query results #4257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ments in query results
adube
force-pushed
the
v2_4-607-auto-links
branch
from
a1d2912
to
75aba94
Compare
|
We have a mix between |
fredj
reviewed
Sep 21, 2018
src/misc/filters.js
Outdated
| * @param {angular.$sce} $sce Angular sce service. | ||
| * @param {!Array.<!ngeox.StringToHtmlReplacement>} | ||
| * ngeoStringToHtmlReplacements List of replacements for string to html. | ||
| * html. |
|
Thanks for the reply.
StringToHtmlReplacements is the global value that is an array, i.e. StringToHtmlReplacement is the ngeox definition of what a single entity of a "replacement" is, that is: the expression and the template when we have a match. i.e.: It think this is okay as it is. Please, let me know if you agree. |
|
@adube ok, understood. Please merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces a new filter in ngeo that allows to return a value as trusted HTML in addition to automatically converting http(s) or email strings into anchor html strings.
StringToHtmlReplacementsis an angular constant that defines expressions that can be converted and a template to use when a string matches.ngeoTrustHtmlAutois the new filter that does likengeoTrustHtml, but will replace strings with html if a match is found.Note: Instead of the regex provided in 607 for the email, I used the one from: https://www.regular-expressions.info/email.html, which is lighter when used in a case-insensitive regex and more robust.