Fix 612 - GMF Drawing, zoom out if feature doesn't fit map view extent #4263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/misc/FeatureHelper.js
Outdated
| @@ -1211,41 +1211,65 @@ exports.prototype.getType = function(feature) { | |||
| * the center of the feature. | |||
| * @param {!ol.Feature} feature Feature. | |||
| * @param {!ol.Map} map Map. | |||
| * @param {boolean=} opt_zoomOut Whether the map should also be zoomed | |||
| * out if the feature would not fit inside the current map view | |||
There was a problem hiding this comment.
rather : if the feature does not fit
adube
force-pushed
the
v2_4-612-drawing-zoom-out
branch
from
3546e3e
to
084672d
Compare
|
@julsbreakdown please approve and merge if you're happy about this pull request ! |
adube
force-pushed
the
v2_4-612-drawing-zoom-out
branch
from
084672d
to
f113bc8
Compare
fredj
approved these changes
Oct 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes https://jira.camptocamp.com/browse/GSGMF-612
In the GMF Drawing tool, when selecting a feature from the list, if the feature would be too big for the current map view extent, then fit the view to the feature instead of just panning to it.