Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing layer param in style function call #4267

Merged
merged 2 commits into from Sep 26, 2018
Merged

Missing layer param in style function call #4267

merged 2 commits into from Sep 26, 2018

Conversation

julsbreakdown
Copy link
Member

@sbrunner sbrunner requested a review from fredj September 25, 2018 11:21
@fredj
Copy link
Member

fredj commented Sep 25, 2018

Thanks @julsbreakdown, I've push a commit to simple the code a bit: the `styleFunction.call? calls are now the same

@julsbreakdown
Copy link
Member Author

@fredj Indeed, looks good =)

@fredj fredj merged commit ec186c6 into 2.3 Sep 26, 2018
@fredj fredj deleted the GSGMF-658-Kml-print branch September 26, 2018 14:11
@kalbermattenm
Copy link
Contributor

Thanks a lot for solving that !

@sbrunner sbrunner added this to the 2.1 milestone Oct 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

@sbrunner sbrunner Awaiting requested review from sbrunner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@julsbreakdown @fredj @kalbermattenm @sbrunner