Add max-zoom setting for point geometries for oedit permalinks #4279
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ger-benjamin
approved these changes
Oct 1, 2018
| @@ -700,8 +707,16 @@ gmf.Permalink.prototype.registerMap_ = function(map, oeFeature) { | |||
| // b) the X, Y and Z available within the permalink service, if available | |||
| if (oeFeature && oeFeature.getGeometry()) { | |||
| const size = map.getSize(); | |||
| const geom = oeFeature.getGeometry(); | |||
There was a problem hiding this comment.
oeFeature.getGeometry() is already called two line upper. Can you call it once (use the variable) ?
pfirpfel
force-pushed
the
max-zoom-fit-oeedit-feature-2.2
branch
from
b720049
to
42af8f0
Compare
pfirpfel
force-pushed
the
max-zoom-fit-oeedit-feature-2.2
branch
from
42af8f0
to
6f3d7da
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see GEO-1465
Test link: http://localhost:3000/contribs/gmf/apps/oeedit/?&objectediting_geomtype=MultiPoint&objectediting_id=Le%20Mol%C3%A9son&objectediting_layer=113&objectediting_theme=ObjectEditing&objectediting_property=name
(You need to be logged into the demo 2.2 backend)
You can create new links here:
http://localhost:3000/contribs/gmf/examples/objecteditinghub.html