API skeleton #4290
API skeleton #4290
Conversation
|
Not complete yet but merging as step 1 |
api/Map.js
Outdated
|
|
||
| // FIXME: temporary | ||
| import SwisstopoSource from '@geoblocks/sources/Swisstopo.js'; | ||
| import EPSG_21781 from '@geoblocks/sources/EPSG21781.js'; |
There was a problem hiding this comment.
Can you use EPSG21781 as in the rest of the project (to search and replace in the future for instance)
api/Map.js
Outdated
|
|
||
| /** | ||
| * @param {string} layer | ||
| * @param {Array.<string>} layer |
api/Map.js
Outdated
| this.view_ = new View({ | ||
| projection: getProjection(constants.projection || 'EPSG:21781'), | ||
| resolutions: constants.resolutions, | ||
| zoom: options.zoom, |
api/Map.js
Outdated
| * @property {function()} [error] | ||
| */ | ||
| addCustomLayer(type, name, url, options = {}) { | ||
| if (type === 'text') { |
There was a problem hiding this comment.
no else ? So perhaps you can avoid this parameter ? (or add a FIXME if you plan to support more types)
There was a problem hiding this comment.
The old api supports text and gpx but the new version only supports text.
Because we need to be compatible with the old api, the type must stay; I've removed the if
api/Map.js
Outdated
| const columns = lines.shift().split('\t'); | ||
| for (const line of lines) { | ||
| if (line) { | ||
| const values = zip(columns, line.split('\t')); |
There was a problem hiding this comment.
(It is cross compatible ? It is always \t ?)
There was a problem hiding this comment.
yes, it's always \t. It was like this in openlayers 2:
https://github.com/openlayers/ol2/blob/master/lib/OpenLayers/Format/Text.js#L91
|
Please feel free to merge |
| @@ -22,6 +24,7 @@ | |||
| "compile-catalog": "buildtools/compile-catalog.js" | |||
| }, | |||
| "devDependencies": { | |||
| "@geoblocks/sources": "https://api.github.com/repos/geoblocks/sources/tarball/173ad0171", | |||
There was a problem hiding this comment.
Do you add a ticket to remove this?
No description provided.