Gmf add loading div onload #4305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julsbreakdown
changed the title
julsbreakdown
force-pushed
the
gmf_add_loading_div_onload
branch
from
124249d
to
02a65df
Compare
This comment has been minimized.
This comment has been minimized.
julsbreakdown
force-pushed
the
gmf_add_loading_div_onload
branch
4 times, most recently
from
14afabf
to
f0823ba
Compare
julsbreakdown
changed the title
julsbreakdown
changed the title
julsbreakdown
force-pushed
the
gmf_add_loading_div_onload
branch
2 times, most recently
from
f2da146
to
f855363
Compare
julsbreakdown
changed the title
julsbreakdown
force-pushed
the
gmf_add_loading_div_onload
branch
from
f855363
to
d0a4a79
Compare
|
Your screen shot are completely different from the mockups... |
|
I do not have access to the mockups... |
|
@sbrunner Can you share them here |
julsbreakdown
force-pushed
the
gmf_add_loading_div_onload
branch
7 times, most recently
from
a48ee4a
to
c504104
Compare
julsbreakdown
force-pushed
the
gmf_add_loading_div_onload
branch
from
c504104
to
4549917
Compare
|
@sbrunner this is ready |
sbrunner
approved these changes
Oct 17, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
see https://jira.camptocamp.com/browse/GSGMF-606
This PR brings a loading mask on both the mobile & desktop application.