685 - Fix ngeo examples #4346
Merged
685 - Fix ngeo examples #4346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbrunner Thanks for the review. Would you please open tasks on JIRA for the following ngeo examples still remaining to be fixed?
For the rotate one, it's a larger issue (it would seem). Would you please create an other task on JIRA mentionning: "FontAwesome 5 not working as text symbols in OpenLayers". That's a total of 3 tasks. Thanks a lot. |
|
You want that I open 3 different tasks? |
Yes, please. |
adube
force-pushed
the
v2_4-685-fix-examples
branch
from
ba882da
to
5fefcaf
Compare
|
I added bootstrap in the ngeo examples common dependencies, which fixed some of the examples that required it (mapquery, bboxquery, etc.). I also made sure that all ngeo examples used urls from the I will merge once Travis is happy. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the ngeo examples that were broken or had minor UI issues.
Fixed examples:
Todo
examples/url.jsfix the mapfishprint example (it currently returns a blank page... I don't think this can be fixed here)will be fixed in a separate PRfix the googlestreetview examplewill be fixed in a separate PRfix the rotate example (FontAwesome version 5 doesn't seem to work with OpenLayers anymore... I tried with OL only and it doesn't work...)will be fixed in a separate PR