Port offline feature #4348
Merged
Port offline feature #4348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Nov 2, 2018
|
Thanks @sbrunner. Do you know why Travis is red? |
gberaudo
force-pushed
the
port_offline_feature
branch
from
acc5c36
to
59c485a
Compare
it tries to download https://raw.githubusercontent.com/camptocamp/demo_geomapfish/master/geoportal/demo_geoportal/locale/en/LC_MESSAGES/demo_geoportal-client.po |
|
This pull request should be rebased ... |
- port the ngeo code to ES6 modules; - port the example. Note that the example is actually broken: OSM layers have never been supported by the offline service (we support WMS and WMTS).
gberaudo
force-pushed
the
port_offline_feature
branch
from
59c485a
to
c4e92a7
Compare
sbrunner
reviewed
Dec 12, 2018
| "dependencies": {} | ||
| "dependencies": { | ||
| "localforage": "^1.7.3" | ||
| } |
There was a problem hiding this comment.
Shouldn't be in devDependencies?
There was a problem hiding this comment.
This is the indexedDB abstraction we use for the offline feature.
It can not be a dev dependency (we want it transitively) but maybe it could be an optional dependency? That would be our first one.
| @@ -1,6 +1,8 @@ | |||
| /** | |||
| * @module ngeo.message.modalComponent | |||
| */ | |||
| import 'jquery'; | |||
| import 'jquery-ui'; | |||
sbrunner
reviewed
Dec 12, 2018
gberaudo
commented
May 20, 2019
gberaudo
commented
May 20, 2019
gberaudo
commented
May 20, 2019
llienher
approved these changes
May 20, 2019
gberaudo
force-pushed
the
port_offline_feature
branch
from
969e6c4
to
c19561f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.