WIP 685 - Fix GMF examples #4349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Work in progress...
This patch fixes the GMF examples to make them work again. It also includes a
url.jsfile for all GMF examples to use.The examples include bootstrap to make some of them work properly.
There's one fix in particular that's outside the scope of the examples, but all of them were failing otherwise due to a missing dependency: the fix to Permalink.js (was missing authentication service to have access to
gmfUser).Still to do
print is not working (error is thrown) - we might want to exclude this one from this PR and create a task out of it in JIRA.We'll create an other issue for this.There are still minor details to fix, but the theme service on demo stopped from responding and prevents me from going on. I'll check again tomorrow.