Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

685 - Fix remaining issues with GMF examples #4355

Merged
merged 2 commits into from Nov 6, 2018

Conversation

adube
Copy link
Contributor

@adube adube commented Nov 5, 2018

This patch includes fixes for the remaining issues with GMF examples (excluding the print one).

  • permalink (well, not entirely the permalink, but more a fix to the popover which wasn't working anymore since the upgrade to Bootstrap 4)
  • search (color chooser)
  • share (emailing popup)
  • wfspermalink (was missing FontAwesome css definition)
  • missing css file to exclude the layer tree from some of the examples

@adube adube requested a review from sbrunner November 5, 2018 19:01
@@ -0,0 +1,3 @@
gmf-layertree {
display: none !important;
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where it is used (imported)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In some examples, we have to include the gmf-layertree otherwise we would not have any layers created from the loaded theme. However, we do not want to showcase the layertree itself, just a specific feature.

For example, in the editfeatureselector example.

Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me :-)

@adube adube force-pushed the v2_4-685-gmf-examples-more-fixes branch from 8cbbcec to 4fb8db7 Compare November 6, 2018 13:57
@adube adube merged commit 9311fa6 into camptocamp:master Nov 6, 2018
@adube adube deleted the v2_4-685-gmf-examples-more-fixes branch November 6, 2018 14:40
@sbrunner sbrunner added this to the 2.4 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants