Update fontawesome classes to work with FT5 #4356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
julsbreakdown
force-pushed
the
GSGMF-698_font_awesome_5
branch
from
ca0c681
to
2310e51
Compare
fredj
reviewed
Nov 6, 2018
| @@ -674,11 +674,11 @@ exports.Controller_.prototype.handleMapContextMenu_ = function(evt) { | |||
| type == ngeoGeometryType.POLYGON || | |||
| type == ngeoGeometryType.RECTANGLE) { | |||
| actions = actions.concat([{ | |||
| cls: 'fa fa-arrows', | |||
There was a problem hiding this comment.
Note: fa-arrows exists but is in the pro "pack"
There was a problem hiding this comment.
Thanks for the info
fredj
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jira.camptocamp.com/browse/GSGMF-698