Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support WMS overlays #4364

Merged
merged 1 commit into from Nov 8, 2018
Merged

Support WMS overlays #4364

merged 1 commit into from Nov 8, 2018

Conversation

adube
Copy link
Contributor

@adube adube commented Nov 7, 2018

Support WMS overlays in JS api.

@fredj Have a quick check and see if I'm on the right track, please.

@adube adube requested a review from fredj November 7, 2018 19:03
@adube adube force-pushed the api_694_layers branch 2 times, most recently from eda4528 to b2a1d28 Compare November 7, 2018 19:18
fredj
fredj approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very good, thanks

@adube
Copy link
Contributor Author

adube commented Nov 8, 2018

@fredj Codacy complained. Can I still merge this?

@sbrunner
Copy link
Member

sbrunner commented Nov 8, 2018

For me yes :-)

@adube adube merged commit fa2f72b into camptocamp:api Nov 8, 2018
@adube adube deleted the api_694_layers branch November 8, 2018 15:34
@sbrunner sbrunner added this to the dummy milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
dummy
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@adube @sbrunner @fredj