Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard source webpack plugin #4365

Merged
merged 2 commits into from Nov 8, 2018
Merged

Hard source webpack plugin #4365

merged 2 commits into from Nov 8, 2018

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Nov 8, 2018 •
edited by gberaudo

The second time of webpack run for desktop will get 17s. instead of 24s.

@sbrunner sbrunner added this to the 2.3 milestone Nov 8, 2018
@sbrunner sbrunner changed the base branch from master to 2.3 November 8, 2018 09:21
gberaudo
gberaudo approved these changes Nov 8, 2018
View reviewed changes
Copy link
Member

@gberaudo gberaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK to test using this. If it breaks or builds we can always revert it.

@sbrunner sbrunner merged commit 779cd0a into 2.3 Nov 8, 2018
@sbrunner sbrunner deleted the HardSourceWebpackPlugin branch November 8, 2018 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberaudo gberaudo gberaudo approved these changes

@fredj fredj Awaiting requested review from fredj

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.3.5
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @gberaudo