Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Permalink authentication required fixes #4368

Merged
merged 2 commits into from Nov 9, 2018

Conversation

arnaud-morvan
Copy link
Member

@arnaud-morvan arnaud-morvan commented Nov 8, 2018

Fix GSGMF-688: Emit the authenticationrequired event even when the function return prematurely in case layertree is empty.

Fix GSGMF-695: Avoid emitting authenticationrequired event for groups whith no check layers (avoid empty string in groupLayersArray).

@arnaud-morvan arnaud-morvan changed the title GSGMF-688 - Emit authenticationrequired even when layertree is empty Permalink authenticationrequired fixes Nov 8, 2018
@arnaud-morvan arnaud-morvan changed the title Permalink authenticationrequired fixes Permalink authentication required fixes Nov 8, 2018
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me

@arnaud-morvan arnaud-morvan merged commit a3946d4 into 2.3 Nov 9, 2018
@arnaud-morvan arnaud-morvan deleted the authenticationrequired_layertree_empty branch November 9, 2018 09:44
@sbrunner sbrunner added this to the 2.3 milestone Nov 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants