Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use between as temporal operator with QGIS #4389

Merged
merged 1 commit into from Jan 29, 2020

Conversation

arnaud-morvan
Copy link
Member

QGIS does not support "During" operator.

@arnaud-morvan
Copy link
Member Author

@sbrunner : it was much simpler than I thought

@sbrunner
Copy link
Member

:-)

@arnaud-morvan
Copy link
Member Author

@sbrunner : I need it in 2.2 for ADL and there is big problem with typing (between take two numbers).
As we might restore type checking, here is a new version with new filter operator that accepts strings.

@sbrunner
Copy link
Member

sbrunner commented Nov 19, 2018

I don't think that there is a big problem, but it can be good to have two different pull requests :-)

@sbrunner sbrunner modified the milestones: 2.3, 2.3.5 Nov 29, 2018
@sbrunner sbrunner modified the milestones: 2.3.6, 2.3 Mar 21, 2019
@arnaud-morvan arnaud-morvan changed the base branch from 2.3 to master January 27, 2020 16:57
@arnaud-morvan
Copy link
Member Author

@sbrunner : I've rebase this old PR, still ok for merge ?

@fredj
Copy link
Member

fredj commented Jan 28, 2020

looks code but src/ol-ext/format/filter.js needs to be converted to es6 modules / classes

@arnaud-morvan arnaud-morvan force-pushed the qgis_temporal_filters branch 2 times, most recently from 5f8dc09 to 140e9d4 Compare January 28, 2020 17:43
@arnaud-morvan
Copy link
Member Author

Thanks, I forgot to remove this file during rebase, done now.

@arnaud-morvan arnaud-morvan merged commit dfb46cb into master Jan 29, 2020
@arnaud-morvan arnaud-morvan deleted the qgis_temporal_filters branch January 29, 2020 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants