Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove unused injected services #4442

Merged
merged 2 commits into from
Dec 5, 2018
Merged

Remove unused injected services #4442

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e59b4a5
Remove goog.require in comment
fredj Dec 4, 2018
a5f54a7
Remove unused injected services
fredj Dec 4, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 1 addition & 3 deletions contribs/gmf/apps/desktop_alt/Controller.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,15 +31,13 @@ if (!window.requestAnimationFrame) {
/**
* @param {angular.IScope} $scope Scope.
* @param {angular.auto.IInjectorService} $injector Main injector.
* @param {ngeo.misc.File} ngeoFile The file service.
* @param {gettext} gettext The gettext service
* @param {angular.IQService} $q Angular $q.
* @constructor
* @extends {gmf.controllers.AbstractDesktopController}
* @ngInject
* @export
*/
const exports = function($scope, $injector, ngeoFile, gettext, $q) {
const exports = function($scope, $injector, gettext) {
gmfControllersAbstractDesktopController.call(this, {
srid: 21781,
mapViewConfig: {
Expand Down
7 changes: 2 additions & 5 deletions contribs/gmf/src/layertree/timeSliderComponent.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,14 +36,12 @@ exports.run(/* @ngInject */ ($templateCache) => {
* @htmlAttribute {ngeox.TimeProperty} gmf-time-slider-time parameter for initialization.
* @htmlAttribute {function()} gmf-time-slider-on-date-selected Expression evaluated after
* date(s) changed
* @param {angular.ITimeoutService} $timeout angular timeout service
* @param {angular.IFilterService} $filter angular filter service
* @return {angular.IDirective} The directive specs.
* @ngInject
* @ngdoc directive
* @ngname gmfTimeSlider
*/
exports.directive_ = function($timeout, $filter) {
exports.directive_ = function() {
return {
scope: {
onDateSelected: '&gmfTimeSliderOnDateSelected',
Expand Down Expand Up @@ -98,15 +96,14 @@ exports.directive('gmfTimeSlider', exports.directive_);

/**
* TimeSliderController - directive controller
* @param {!angular.IScope} $scope Angular scope.
* @param {ngeo.misc.WMSTime} ngeoWMSTime WMSTime service.
* @constructor
* @private
* @ngInject
* @ngdoc controller
* @ngname gmfTimeSliderController
*/
exports.Controller_ = function($scope, ngeoWMSTime) {
exports.Controller_ = function(ngeoWMSTime) {

/**
* @type {ngeo.misc.WMSTime}
Expand Down
1 change: 0 additions & 1 deletion contribs/gmf/src/objectediting/component.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,6 @@ exports.component('gmfObjectediting', component);
* query service.
* @param {!gmf.layertree.TreeManager} gmfTreeManager The gmf TreeManager service.
* @param {!ngeo.misc.FeatureHelper} ngeoFeatureHelper Ngeo feature helper service.
goog.require('ngeo.map.LayerHelper');
* @param {!ngeo.map.LayerHelper} ngeoLayerHelper Ngeo Layer Helper.
* @param {!ngeo.misc.ToolActivateMgr} ngeoToolActivateMgr Ngeo ToolActivate manager
* service.
Expand Down