Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get setting from JSON #4443

Merged
merged 1 commit into from Dec 7, 2018
Merged

Get setting from JSON #4443

merged 1 commit into from Dec 7, 2018

Conversation

sbrunner
Copy link
Member

@sbrunner sbrunner commented Dec 5, 2018

No inline script
No Javascript on server side

@sbrunner sbrunner added this to the 2.4 milestone Dec 5, 2018
@sbrunner sbrunner force-pushed the json-settings branch 3 times, most recently from ddb0a9b to 6954ed7 Compare December 5, 2018 09:45
Copy link
Member

@gberaudo gberaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks very nice!
Maybe we should add some CHANGES.md file somewhere explaining bootstrap should be done manually now.

@sbrunner sbrunner force-pushed the json-settings branch 2 times, most recently from e30a899 to 26431be Compare December 6, 2018 10:26
@sbrunner
Copy link
Member Author

sbrunner commented Dec 6, 2018

@gberaudo done :-)

CHANGES.md Outdated Show resolved Hide resolved
CHANGES.md Outdated Show resolved Hide resolved
@sbrunner
Copy link
Member Author

sbrunner commented Dec 6, 2018

Thanks @gberaudo, done :-)

No inline script
No JavaScript on server side
@sbrunner sbrunner merged commit 2b879a1 into master Dec 7, 2018
@sbrunner sbrunner deleted the json-settings branch December 7, 2018 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants