Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove all goog.assert #4535

Merged
merged 16 commits into from Jan 21, 2019
Merged

Remove all goog.assert #4535

merged 16 commits into from Jan 21, 2019

Conversation

sbrunner
Copy link
Member

No description provided.

@sbrunner
s/googAsserts\.assert(/console.assert(/g
f060130
@sbrunner
s/googAsserts\.assertNumber(\(.*\));/console.assert(typeof \1 == numb…
3843364 
…er);/g
@sbrunner
s/googAsserts\.assertString(\(.*\));/console.assert(typeof \1 == stri…
c4fa248 
…ng);/g
@sbrunner
s/googAsserts\.assertBoolean(\(.*\));/console.assert(typeof \1 == boo…
62c36f3 
…lean);/g
@sbrunner
s/googAsserts\.assertArray(\(.*\));/console.assert(Array.isArray(\1));/g
cdc6887
@sbrunner
s/googAsserts\.assertFunction(\(.*\));/console.assert(typeof \1 == fu…
0a4d14e 
…nction);/g
@sbrunner
s/googAsserts\.assertInstanceof(\(.\+\), \(.\+\));/console.assert(\1 …
0562c51 
…instanceof \2);/g
@sbrunner
s/googAsserts\.assertElement(/console.assert(/g
49b3045
@sbrunner
s/googAsserts\.assertObject(/console.assert(/g
d2fee87
@sbrunner
s/ == function/ == 'function'/g
35af48c
@sbrunner
s/ == boolean/ == 'boolean'/g
1ad8175
@sbrunner
s/ == string/ == 'string'/g
81cda6a
@sbrunner
s/ == number/ == 'number'/g
fd5ed55
@sbrunner
/^import googAsserts from 'goog\/asserts.js';$/d
6b4480c
@sbrunner
s/googAsserts\.fail(/console.assert(false, /g
cb58bad
@sbrunner sbrunner added this to the 2.4 milestone Jan 21, 2019
@sbrunner sbrunner requested a review from fredj January 21, 2019 12:15
@sbrunner sbrunner force-pushed the rm-goog-assert branch 2 times, most recently from 0391565 to bb17d3e Compare January 21, 2019 14:50
@sbrunner sbrunner merged commit cb078fa into master Jan 21, 2019
@sbrunner sbrunner deleted the rm-goog-assert branch January 21, 2019 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fredj fredj fredj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sbrunner @fredj