Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't set remove url to undefined #4575

Merged
merged 4 commits into from Feb 1, 2019
Merged

Don't set remove url to undefined #4575

merged 4 commits into from Feb 1, 2019

Conversation

fredj
Copy link
Member

@fredj fredj commented Feb 1, 2019 •
edited

It breaks the search:
https://camptocamp.github.io/ngeo/master/examples/contribs/gmf/apps/desktop.html

also broken:

  • no context menu in draw feature
  • gmf-contextualdata: no css styling (arrow, ...)
  • gmf-contextualdata: popup doesn't disappear

@fredj fredj requested a review from sbrunner February 1, 2019 08:36
sbrunner
sbrunner approved these changes Feb 1, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :-)

@fredj fredj merged commit b4b5395 into master Feb 1, 2019
@fredj fredj deleted the fix_search branch February 1, 2019 09:24
@sbrunner sbrunner added this to the 2.4 milestone Feb 6, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredj @sbrunner