Even more typecheck fixes for gmf #4588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbrunner
approved these changes
Feb 5, 2019
fredj
reviewed
Feb 5, 2019
| * @return {string} Filter condition | ||
| * @export | ||
| */ | ||
| get filterCondition() { |
There was a problem hiding this comment.
why do we need to have getter and setter for this variable ?
There was a problem hiding this comment.
- This variable needs to be changed. In the filter component, one can set OR instead of AND, which affect this variable, thus it needs a setter
- It needs a getter because we bind UI components to it
- If you look around the other properties of the data source classes, you'll notice that they have getters/setters as well and those we're removed. If this one was removed, then why not the others?
- Back then, when this was first implemented, it was my first time writing ES6 classes, and the use of getters/setters seemed quite nice and it was working with Angular well. This was a good choice.
- The typecheck complains that there is not a filterCondition property set. Is this because inner properties can't be accessed?
Please, comment. Thanks.
There was a problem hiding this comment.
ok, so it was changed ("simple" public variable to getter / setter) for the typecheck ?
There was a problem hiding this comment.
I don't know why it was changed. It was using a getter/setter before and it was working fine.
adube
force-pushed
the
fix-types-gmf
branch
2 times, most recently
from
9df77f7
to
8a4d6fc
Compare
sbrunner
reviewed
Feb 6, 2019
|
Please, let me know if I can merge this. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As title says.
I noticed that the getter/setters
filterConditionfor ngeo/datasource/OGC have been removed. Why?