Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activate types check on ngeo #4618

Merged
merged 1 commit into from
Feb 12, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -65,7 +65,7 @@ script:
#- npm run typecheck
# Generate API doc
- npm install --prefix openlayers_src https://api.github.com/repos/openlayers/openlayers/tarball/v5.3.0
#- '! (npm run typecheck|sed -r "s/\x1B\[([0-9]{1,2}(;[0-9]{1,2})?)?[mGK]//g"|grep ^src)'
- '! (npm run typecheck|sed -r "s/\x1B\[([0-9]{1,2}(;[0-9]{1,2})?)?[mGK]//g"|grep ^src)'
- '! (npm run typecheck|grep api)'
- '! (npm run typecheck|grep gmf)'
- '! (npm run typecheck|grep test)'
Expand Down
1 change: 0 additions & 1 deletion api/src/constants.js
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

import EPSG21781 from '@geoblocks/proj/src/EPSG_21781.js';
import EPSG2056 from '@geoblocks/proj/src/EPSG_2056.js';

Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/elevation.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import angular from 'angular';
import appURL from './url.js';
import './elevation.css';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/lidarprofile.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import './lidarprofile.css';
import angular from 'angular';
import gmfMapComponent from 'gmf/map/component.js';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/mobilemeasure.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import angular from 'angular';
import appURL from './url.js';
import './mobilemeasure.css';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/mouseposition.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import './mouseposition.css';
import angular from 'angular';
import gmfMapModule from 'gmf/map/module.js';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/objectediting.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import angular from 'angular';
import appURL from './url.js';
import './objectediting.css';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/permalink.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import './permalink.css';
import angular from 'angular';
import gmfMapModule from 'gmf/map/module.js';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/print.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import angular from 'angular';
import appURL from './url.js';
import './print.css';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/profile.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import angular from 'angular';
import appURL from './url.js';
import './profile.css';
Expand Down
3 changes: 0 additions & 3 deletions contribs/gmf/examples/wfspermalink.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import angular from 'angular';
import appURL from './url.js';
import './wfspermalink.css';
Expand Down
3 changes: 2 additions & 1 deletion contribs/gmf/src/mobile/navigation/component.js
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,8 @@ import angular from 'angular';
/**
* @type {!angular.IModule}
* @hidden
*/const module = angular.module('gmfMobileNav', []);
*/
const module = angular.module('gmfMobileNav', []);


/**
Expand Down
3 changes: 0 additions & 3 deletions examples/asitvd.js
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
/**
*/

import './asitvd.css';
import angular from 'angular';
import ngeoSourceAsitVD from 'ngeo/source/AsitVD.js';
Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@
"node-sass": "4.11.0",
"node-sass-importer": "1.0.0",
"ol": "5.3.0",
"ol-cesium": "2.6.0",
"ol-cesium": "2.7.2",
"ol-layerswitcher": "3.2.0",
"phantomjs-polyfill-string-includes": "1.0.0",
"phantomjs-prebuilt": "2.1.16",
Expand Down
9 changes: 4 additions & 5 deletions src/misc/php-date-formatter.js
Original file line number Diff line number Diff line change
Expand Up @@ -42,11 +42,10 @@ function _compare(str1, str2) {

/**
* @private
* @template T
* @param {T} value Value
* @param {Object} value Value
* @param {number} length Length
* @param {string} chr Char
* @returns {T}
* @param {string} [chr] Char
* @returns {string}
*/
function _lpad(value, length, chr) {
const val = value.toString();
Expand All @@ -56,7 +55,7 @@ function _lpad(value, length, chr) {

/**
* @private
* @param {Object} out Out
* @param {Object} [out] Out
* @returns {Object}
*/
function _extend(out) {
Expand Down