Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new ngeo-draggable-handle option to modalComponent #4626

Merged
merged 1 commit into from Feb 12, 2019

Conversation

fredj
Copy link
Member

@fredj fredj commented Feb 11, 2019

@gberaudo
Copy link
Member

@sbrunner, @ybolognini, we found out the issue with have with the Luxembourg app is due to a bug in ngeo. The chrome browser in Android does not support our clicks inside draggable boxes.

Currently modals are draggable: the user can drag any part of the modal and move it around.

A reasonable workaround would be to:

  • restrict drag to the modal headers (the text part only).

Bonus questions:

  • does it make sense for modals to be draggable?
  • are there other parts of ngeo/gmf that are impacted by this issue?
  • can this be fixed for 2.4?

@gberaudo gberaudo added this to the 2.4 milestone Feb 11, 2019
@fredj fredj requested a review from sbrunner February 12, 2019 08:06
@fredj fredj changed the title [WIP] Add new ngeo-draggable-handle option to modalComponent Add new ngeo-draggable-handle option to modalComponent Feb 12, 2019
@fredj fredj removed the question label Feb 12, 2019
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@fredj fredj merged commit 0fbcfea into master Feb 12, 2019
@fredj fredj deleted the ngeo-draggable-handle branch February 12, 2019 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants