Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GMF Print - support sending printed file to email #4633

Merged
merged 3 commits into from Feb 15, 2019

Conversation

adube
Copy link
Contributor

@adube adube commented Feb 12, 2019

This patch introduces sending a printed file using the GMF Print tool to an email. The specs are described in this task: https://jira.camptocamp.com/browse/GSGMF-738

It is not yet completed, as there are things remaining to do:

  • show a message about the file that is going to be sent by email
  • the request, when using the email, currently doesn't work. More details to come in a comment.

@adube adube requested review from fredj and sbrunner February 12, 2019 15:36
@adube
Copy link
Contributor Author

adube commented Feb 12, 2019

@sbrunner When trying to print using the parameters, it didn't work. I got this error response from the server.

javax.net.ssl.SSLException: Unrecognized SSL message, plaintext connection?

Would you please try the patch and see if you get the same error?

@camptocamp camptocamp deleted a comment from adube Feb 12, 2019
Copy link
Member

@fredj fredj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good, I'll let @sbrunner comment about the ssl error

@sbrunner
Copy link
Member

I fix the error on sending email, but the client shouldn't pool the print to wait on the job...

@adube
Copy link
Contributor Author

adube commented Feb 14, 2019

I fix the error on sending email, but the client shouldn't pool the print to wait on the job...

How do you suggest we do that?

@adube
Copy link
Contributor Author

adube commented Feb 14, 2019

I just tried it and it didn't work.

I got an error:

console.js:35 org.locationtech.jts.util.AssertionFailedException: Expected 200 OK but encountered 400 BAD_REQUEST: Http status code for https://geomapfish-demo-dc.camptocamp.com/2.4/mapserv_proxy?MAP_RESOLUTION=…34%2C179503.875%2C637358.7916666667%2C191410.125&VERSION=1.1.1&SERVICE=WMS was not OK. It was: 400 BAD_REQUEST. The response message was: 'Bad Request'

I did not get an e-mail.

@sbrunner Any idea?

@sbrunner
Copy link
Member

When we click on image or PDF and the send email is checker we just send the request on report.pdf, and display the message :-)

@adube
Copy link
Contributor Author

adube commented Feb 14, 2019

When we click on image or PDF and the send email is checker we just send the request on report.pdf, and display the message :-)

OK, I think I understand what you mean. However, I'm not that familiar with the code so I don't know what that implies yet. I also suspect that regardless if I make those changes or not, the request asking for a file being sent should have worked and it didn't.

I suggest we make sure that the current version works with the file, then we make your suggested changes.

@sbrunner
Copy link
Member

OK, looks good to me :-)

@adube
Copy link
Contributor Author

adube commented Feb 14, 2019

OK, looks good to me :-)

Ok thanks. Do you want to take a look at the error before we merge this? I would like to see this feature working before merging it.

@sbrunner
Copy link
Member

Now the error, is as I see, completely fixed :-)

@fredj fredj merged commit d8173b3 into camptocamp:master Feb 15, 2019
@adube adube deleted the 738-gmf-print-email branch February 15, 2019 12:58
@sbrunner sbrunner added this to the 2.4 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants