New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GMF Print - support sending printed file to email #4633
Conversation
@sbrunner When trying to print using the parameters, it didn't work. I got this error response from the server.
Would you please try the patch and see if you get the same error? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code looks good, I'll let @sbrunner comment about the ssl error
I fix the error on sending email, but the client shouldn't pool the print to wait on the job... |
8730602
to
89c844d
Compare
How do you suggest we do that? |
I just tried it and it didn't work. I got an error:
I did not get an e-mail. |
When we click on |
OK, I think I understand what you mean. However, I'm not that familiar with the code so I don't know what that implies yet. I also suspect that regardless if I make those changes or not, the request asking for a file being sent should have worked and it didn't. I suggest we make sure that the current version works with the file, then we make your suggested changes. |
OK, looks good to me :-) |
Ok thanks. Do you want to take a look at the error before we merge this? I would like to see this feature working before merging it. |
Now the error, is as I see, completely fixed :-) |
This patch introduces sending a printed file using the GMF Print tool to an email. The specs are described in this task: https://jira.camptocamp.com/browse/GSGMF-738
It is not yet completed, as there are things remaining to do: