Be able to limit layers on raster service #4651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Feb 18, 2019
| @@ -196,7 +199,7 @@ exports.Controller_.prototype.setContent_ = function(coordinate) { | |||
| const getRasterError = function(resp) { | |||
| console.error('Error on getting the raster.'); | |||
| }; | |||
| this.gmfRaster_.getRaster(coordinate).then( | |||
| this.gmfRaster_.getRaster(coordinate, this.gmfContextualdataOptions.rasterParams || {}).then( | |||
There was a problem hiding this comment.
Suggested change
| this.gmfRaster_.getRaster(coordinate, this.gmfContextualdataOptions.rasterParams || {}).then( | |
| this.gmfRaster_.getRaster(coordinate, this.gmfContextualdataOptions.rasterParams).then( |
The getRaster function can already accept undefined as param
fredj
reviewed
Feb 18, 2019
| @@ -139,6 +139,9 @@ exports.Controller_ = function($compile, $timeout, $scope, gmfRaster) { | |||
| */ | |||
| this.gmfRaster_ = gmfRaster; | |||
|
|
|||
| this.gmfContextualdataOptions = $injector.has('gmfContextualdataOptions') ? | |||
There was a problem hiding this comment.
add a @type and set it to @private
fredj
approved these changes
Feb 18, 2019
sbrunner
force-pushed
the
contextualdata-raster-layers
branch
from
5a9e6fc
to
1d64f4b
Compare
With the option `gmfContextualdataOptions`:
{
'rasterParams': {
'layers': 'srtm'
}
}
sbrunner
force-pushed
the
contextualdata-raster-layers
branch
from
1d64f4b
to
610fccd
Compare
|
Thanks @sbrunner, it's working. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the option
gmfContextualdataOptions:{ "rasterParams": { "layers": "srtm" } }Fix https://jira.camptocamp.com/browse/GSGMF-781