Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use getType instead of instanceof #4668

Merged
merged 1 commit into from Feb 21, 2019
Merged

Use getType instead of instanceof #4668

merged 1 commit into from Feb 21, 2019

Conversation

fredj
Copy link
Member

@fredj fredj commented Feb 21, 2019

Simplify the code by using the getType function instead of instanceof

sbrunner
sbrunner approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@sbrunner sbrunner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :-)

@fredj fredj merged commit 78637e2 into master Feb 21, 2019
@fredj fredj deleted the cleanup branch February 21, 2019 10:16
@sbrunner sbrunner added this to the 2.4 milestone Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@fredj @sbrunner