Update current theme after loadThemes call is done #4685
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredj
reviewed
Feb 26, 2019
sbrunner
requested changes
Feb 26, 2019
Co-Authored-By: pfirpfel <michaelkuenzli@gmail.com>
pfirpfel
force-pushed
the
2.2-switch-to-default-non-public-theme
branch
from
6faf3de
to
47910ed
Compare
sbrunner
approved these changes
Feb 26, 2019
sbrunner
requested changes
Feb 26, 2019
|
@fredj Do you know why we have this |
One reason I see, is that every login and logout produces a second call with gmf.AuthenticationEventType.READY. May be we can remove this if clause and change the listener to listenOnce below:
|
pfirpfel
changed the title
sbrunner
approved these changes
Feb 26, 2019
sbrunner
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the updateCurrentTheme_ call happens before the loadThemes call. This is problematic if you log in as an user who has a default theme that is non-public. At the time updateCurrentTheme_ gets called, this non-public theme is not available. It will be, after the loadThemes call has finished. That's why updateCurrentTheme_ should happen after loadThemes.