Fix apply filter #4691
Merged
Fix apply filter #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes the filters component, more specifically when applying a filter.
The bug why it wasn't working anymore is simply because the OpenLayers getUid utils method used to return numbers. Now, it returns strings. There were a lot of places in ngeo/gmf that this value was used as number and was automatically changed as string, but that caused errors. Some of them were reverted like what they were before: numbers.
However, this caused a simple logic issue with the filter while checking onto what data source to apply it. Casting it to string then does the trick.