793 - Fix GMF edit feature stop editing while dirty #4698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adube
force-pushed
the
793-fix-edit-modal
branch
from
2c2f14c
to
05e5908
Compare
fredj
approved these changes
Feb 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the GMF feature editing tool, while trying to stop editing when there a feature is selected and dirty, a modal opens asking for confirmation. In the process of applying the cancel, the modal gets hidden with an animation for a short period of time. If we cancel right away, the modal gets destroyed while animating and the result is we have the modal backdrop still there.
This patch lets the modal do its animation then apply the cancel.