Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font name used in OpenLayers text style #4704

Merged
merged 1 commit into from Mar 1, 2019
Merged

Fix font name used in OpenLayers text style #4704

merged 1 commit into from Mar 1, 2019

Conversation

fredj
Copy link
Member

@fredj fredj commented Mar 1, 2019

Use Font Awesome 5 Free instead of FontAwesome and weight 900 instead of normal (alias to 400)

@fredj
Fix font name used in OpenLayers text style
1ed74c1 
Use `Font Awesome 5 Free` instead of `FontAwesome` and weight `900` instead of `normal` (alias to `400`)
@fredj fredj merged commit 8085e9b into master Mar 1, 2019
@fredj fredj deleted the GSGMF-800 branch March 1, 2019 10:41
@arnaud-morvan
Copy link
Member

@fredj: For curiosity, it works with '900 30px "Font Awesome 5 Free"' but not with 'normal 30px "Font Awesome 5 Free"' ?

@fredj
Copy link
Member Author

fredj commented Mar 1, 2019

@arnaud-morvan yes, because normal s equal to 400and we do not have this weight

@sbrunner sbrunner added this to the 2.4 milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunner sbrunner sbrunner approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2.4
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fredj @arnaud-morvan @sbrunner