Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for error in tooltip config type checking with IE11 #4705

Merged
merged 1 commit into from Mar 1, 2019

Conversation

arnaud-morvan
Copy link
Member

No description provided.

@arnaud-morvan arnaud-morvan requested a review from fredj March 1, 2019 10:25
@arnaud-morvan arnaud-morvan changed the title snapshot Workaround for error in tooltip config type checking with IE11 Mar 1, 2019
@arnaud-morvan arnaud-morvan force-pushed the GSGMF-805-tooltip-sanitize branch 2 times, most recently from e8ec0cf to c5a9797 Compare March 1, 2019 11:07
@arnaud-morvan
Copy link
Member Author

@fredj, @sbrunner : I did not manage to please typecheck (npm run typecheck).

@arnaud-morvan
Copy link
Member Author

Seems I got it with @ts-ignore.
Note that typecheck compare bs.tooltip config to jqueryui.TooltipOption, which is completely different object.

@fredj
Copy link
Member

fredj commented Mar 1, 2019

try to force the type with:

 body.tooltip(/** @type {Bootstrap.TooltipOption} */ ({
      container: 'body',
      trigger: 'hover',
      selector: '[data-toggle="tooltip"]',

      // Avoid error in config type checking with IE11
      sanitizeFn: $injector.get('$sanitize')
    }));

@arnaud-morvan
Copy link
Member Author

@fredj: perfect, thanks.

@arnaud-morvan arnaud-morvan merged commit 601f0ff into master Mar 1, 2019
@arnaud-morvan arnaud-morvan deleted the GSGMF-805-tooltip-sanitize branch March 1, 2019 13:56
@sbrunner sbrunner added this to the 2.4 milestone Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants